Skip to content

Split eta-expansion from seal #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

This is a first step towards making it simpler to unseal Expr and seal Term.
In particular it makes e.unseal.seal === e for any expression e and t.seal.unseal === t for any term t that is a valid expression.

@nicolasstucki nicolasstucki self-assigned this Nov 12, 2019
@nicolasstucki nicolasstucki force-pushed the split-eta-expansion-from-seal branch from d2a9c99 to ac9bb28 Compare November 12, 2019 09:57
@nicolasstucki nicolasstucki marked this pull request as ready for review November 12, 2019 10:35
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR makes eta-expansion explicit, I think it's a good change --- no magic behind scene, and every step explainable.

@nicolasstucki nicolasstucki merged commit 97c386f into scala:master Nov 12, 2019
@nicolasstucki nicolasstucki deleted the split-eta-expansion-from-seal branch November 12, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants